-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump GAMS version in nightly CI worklow #892
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
=======================================
- Coverage 95.6% 95.6% -0.1%
=======================================
Files 46 46
Lines 4335 4337 +2
=======================================
Hits 4147 4147
- Misses 188 190 +2
|
I've been looking at events that trigger CI runs and I've stumbled upon pull_request_target. If I'm not mistaken, this can close #603 since the nightly tests will now automatically run on every PR that changes any GAMS file ( |
message_ix/tests/test_nightly.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test seems to not be considered for our coverage report, so new lines here are considered untested. I'd argue this should not stop this PR, though.
25373df
to
8bae60e
Compare
- '**.gpr' | ||
- '**.gdx' | ||
types: | ||
- labeled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, our secrets could be extracted by any workflow changing GAMS files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the tests passed before, so I disabled them again. They won't run when we apply a label to this PR because it would need to clear both filters, i.e. change some GAMS files and get a label to run.
8bae60e
to
3c16a74
Compare
Similar to iiasa/message-ix-models#250 (review), I'm hoping today's nightly CI test failure also just arises from an incompatibility of using an older GAMS version but a newer GAMS license for this kind of run. This PR thus bumps the GAMS version in the nightly workflow and temporarily enables them to make sure the fix works.
How to review
PR checklist