Run the validation and region-processing #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phackstock
reviewed
Sep 6, 2023
| return df | ||
|
|
||
| # Run the validation and region-processing | ||
| dsd = DataStructureDefinition(here / "definitions") |
There was a problem hiding this comment.
Not sure if we want this as default as we don't have any definitions or mappings.
This would fail out of the box if used for a Scenario Explorer workflow.
Then again, if we just need a pipe through we don't need to set up a workflow directory at all.
There was a problem hiding this comment.
I think the „reminder“ that you still have to define variables and regions is a feature, not a bug
phackstock
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just spent a few minutes debugging the ELEVATE-workflow until realizing that the workflow.py simply didn't run the processing...