Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Recipe 0014 and add add_item() to AccompanyingCanvas #200

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

markpbaggett
Copy link
Contributor

What does this do?

  1. This adds a solution for Recipe 0014.
  2. Attempts to address Issue 199 by making add_item() available to AccompanyingCanvas.
  3. Adds a test to check that members of items in AccompanyingCanvas are AnnotationPages when added with add_item().

@glenrobson
Copy link
Contributor

Sorry to be a pain @markpbaggett but would it be possible to implement the baseurl like Mike has done in the following pull request:

https://github.com/iiif-prezi/iiif-prezi3/pull/183/files

it will make the recipes more consistent and I'm hoping another push might allow me to approve the workflows to run now you are apart of the github team.

@markpbaggett
Copy link
Contributor Author

@glenrobson, not a pain at all! I'm happy to do it and think this will look much better. I'll work on this tonight.

@markpbaggett
Copy link
Contributor Author

@glenrobson, I've added the base_url pattern here.

@glenrobson
Copy link
Contributor

Great thanks! All the checks ran as well this time.

@glenrobson glenrobson merged commit 07c867a into iiif-prezi:main Dec 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants