Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed one memory leak #90

Open
wants to merge 1 commit into
base: trinity-wotlk-ai
Choose a base branch
from
Open

Fixed one memory leak #90

wants to merge 1 commit into from

Conversation

kelno
Copy link

@kelno kelno commented Jun 26, 2018

Destructors of classes inheriting from ChatFilter did not get called.

For example:
RtiChatFilter has a member list<std::string> rtis; which was never destroyed.

Destructors of class inheriting from ChatFilter did not get called
ike3 pushed a commit that referenced this pull request Apr 10, 2022
* Fix .ticket response & .ticket close handling

- Now the GMTicket::SetResponseText method will save the response to the right ticket and will nor update all ticket responses for the same character
- Fix potential issue in GMTicketMgr::Create : limiting to the the most recent ticket of the player and avoid potential multiple returns if there is inconsistent data in table
- Fix GMTicket::SetText
- Prevent to update ticket_text for old tickets of the same char when submiting ticket or updating ticket text in game
- Fix item_text GUID generation
- Setting system response when ticket closed without mail response
- Create a PSendSysMessageMultiline function , will split a mangos string in multiple lines if "@@" string is found.

* Fix revision.h after structure change

Need apply Rel21_16_053_GM_tickets_handling_fixes.sql in order to work correctly
ike3 pushed a commit that referenced this pull request Jul 3, 2022
…for MangosZero (#90)

* Command reorg
Co-authored-by: Elmsroth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant