Removed return value assignment for debugfs_create_u32 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iksaif
reviewed
Jul 10, 2020
| @@ -1138,7 +1138,7 @@ static int thinkpad_wmi_debugfs_init(struct thinkpad_wmi *thinkpad) | |||
| thinkpad->debug.root, | |||
| &thinkpad->debug.instance); | |||
|
|
|||
| dent = debugfs_create_u32("instances_count", S_IRUGO, | |||
| debugfs_create_u32("instances_count", S_IRUGO, | |||
| thinkpad->debug.root, | |||
| &thinkpad->debug.instances_count); | |||
| if (!dent) | |||
There was a problem hiding this comment.
I think you want to remove this too no ?
There was a problem hiding this comment.
sorry I'm a bit confused - isn't line 1141 where I already removed dent = ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the last pull request I made: #16
Trying to install on a newer kernel version (specifically 5.7.7-arch1-1), caused compilation errors with the assignment
Removing
dent =seems to fix this compilation error.The patch is listed here: https://linuxlists.cc/l/1/linux-kernel/t/3537734/(patch)_debugfs:_remove_return_value_of_debugfs_create_u32()#post3537734 - but isn't reflected in the kernel docs (https://www.kernel.org/doc/Documentation/filesystems/debugfs.txt).
This may break older kernel versions, I don't have older devices to test on sorry.