add support for \[ and \] math blocks #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copy pasting text from/to latex, one of the main pain is to change all $$ ... $$ blocks to \[ ... \]
ecstrema
commented
Feb 5, 2022
| @@ -106,18 +106,24 @@ function math_block(state, start, end, silent){ | |||
| max = state.eMarks[start] | |||
|
|
|||
| if(pos + 2 > max){ return false; } | |||
| if(state.src.slice(pos,pos+2)!=='$$'){ return false; } | |||
|
|
|||
| /** @type {readonly ['$$', '\\['} */ | |||
There was a problem hiding this comment.
are type annotations accepted? Should I remove them?
ecstrema
commented
Feb 5, 2022
| lastPos = state.src.slice(0,max).lastIndexOf('$$'); | ||
| lastLine = state.src.slice(pos,lastPos); | ||
| found = true; | ||
| for (const delim of rightDelimiters) { |
There was a problem hiding this comment.
is the usage of for-of prohibited for browser compat?
ecstrema
commented
Feb 5, 2022
| @@ -148,7 +156,7 @@ function math_block(state, start, end, silent){ | |||
| + state.getLines(start + 1, next, state.tShift[start], true) | |||
| + (lastLine && lastLine.trim() ? lastLine : ''); | |||
| token.map = [ start, state.line ]; | |||
| token.markup = '$$'; | |||
| token.markup = startDelim; | |||
There was a problem hiding this comment.
what happens to the token markup when the start and end character isn't the same. Is it even supported?
|
Note that this coding style is quite foreign to me, so I hope I have put the spaces where needed. |
wdhongtw
pushed a commit
to wdhongtw/markdown-it-katex
that referenced
this pull request
Jul 24, 2024
Fix nested begin/end for inline bare block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copy pasting text from/to latex, one of the main pain is to change all $$ ... $$ blocks to [ ... ]
Not that although I opened this PR, there are a few questions and things to resolve before it can be merged.
I'll leave them as comments and mark the pr as draft for now.