re-route users without elevated privileges from course admin pages to error page. #8217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
403verboten
branch
2 times, most recently
from
bfbcab3 to
907f73c
Compare
stopfstedt
force-pushed
the
403verboten
branch
3 times, most recently
from
9aff3b1 to
6bc5d2b
Compare
stopfstedt
force-pushed
the
403verboten
branch
from
6bc5d2b to
3bf1fcf
Compare
accessing the session page as a non-privved user redirects now to an error page. which makes this test obsolete. i renamed the counterpart test accordingly while at it.
perms check happens before data availability, as it should be. ensuring here that the test user has privileged access.
ensure that test user has proper perms before interacting with instructor group management.
users without elevated privs get routed to the 404 page.
stopfstedt
force-pushed
the
403verboten
branch
from
967e581 to
5f3b664
Compare
stopfstedt
force-pushed
the
403verboten
branch
from
4e28a3d to
02051a8
Compare
stopfstedt
requested review from
jrjohnson and
michaelchadwick
as code owners
jrjohnson
approved these changes
Nov 27, 2024
|
|
||
| titleToken = 'general.coursesAndSessions'; | ||
| editable = false; | ||
| #preloadTopLevel = null; | ||
|
|
||
| beforeModel(transition) { | ||
| this.session.requireAuthentication(transition, 'login'); | ||
| if (!this.currentUser.performsNonLearnerFunction) { | ||
| // Slash on the route name is necessary here due to this bug: | ||
| // https://github.com/emberjs/ember.js/issues/12945 |
| @@ -19,6 +21,9 @@ export default class CourseIndexRoute extends Route { | |||
|
|
|||
| beforeModel(transition) { | |||
| this.session.requireAuthentication(transition, 'login'); | |||
| if (!this.currentUser.performsNonLearnerFunction) { | |||
There was a problem hiding this comment.
I'm pretty sure the beforeModel hook in the course route will fire and redirect before this one is hit making this code unnecessary. The same is true of the this.session.requireAuthentication(transition, 'login'); so maybe better to have it in both places and be sure?
michaelchadwick
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this affects the course details page and sub-pages (like session management) that share the same root path
/courses/{id}/, and other course-management related routes.it's a foot in the door - i'll lock other admin areas such as instructor group/learner group management down in consecutive steps.
refs ilios/ilios#5721