Moodle 4.5 upgrade #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these buttons served no purpose, looks like they were kruft from an earlier iteration on this form.
…ding callback action. this was left incomplete - the UI controls seems to never have materialized for this.
the edit instance for variant has all selectors locked down, there is no need to make that form dynamic with javascript. what's worse - it currently throws a client-side exception (only visible in browser console) when the edit form is pulled up.
this needed to be rewritten from scratch since YUI is finally about to be removed from Moodle. to keep friction in this transition to a minimum, i tried to stay as close as possible to the flow of the original implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #47
fixes #77
i tried to break this out into discrete chunks to make review easier. the big change is in commit 4635c74.