Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unified-domain to solve porous flow #1001

Draft
wants to merge 81 commits into
base: main
Choose a base branch
from
Draft

Add unified-domain to solve porous flow #1001

wants to merge 81 commits into from

Conversation

tulioricci
Copy link
Collaborator

@tulioricci tulioricci commented Feb 21, 2024

  • Include capability for non-mixture gases to the currently implemented porous media flows (i.e., without "coupling")
  • Update limiter function in gas_model - make_fluid_state
  • Implement unified-domain approach to solve porous-media and pure-fluid flows in a single domain, without explicit coupling between multiple domains.
    • pass material densities to the boundary constructor
    • modify inviscid flux call to be able to handle both pure-gas or "coupled" porous flows. In current status, the cv.energy accounts for both solid and gas energies, however the flux can NOT include the solid energy.
    • update materials initializer to handle porous flows

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@tulioricci tulioricci changed the base branch from main to tulio/phenolics February 21, 2024 01:32
@tulioricci tulioricci changed the base branch from tulio/phenolics to tulio/update_mat_intfce March 1, 2024 00:48
@tulioricci tulioricci changed the base branch from tulio/update_mat_intfce to main May 15, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant