Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scheduled grading run details table #138

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Conversation

Xiangmingchen
Copy link
Collaborator

@Xiangmingchen Xiangmingchen commented Mar 25, 2021

Screen.Recording.2021-03-24.at.8.31.59.PM.mp4

Features added

  • Add "details" button to each scheduled run. Both staff and admin can see this button (unlike "edit")
  • When clicked, a table shows up underneath with all student grading jobs' information
  • Each grading job has netid, job id, check status button, and check log button
  • [Unrelated] Added spinner when log is loading

Broadway endpoint integration

Used grading run env endpoint to pair up student netids and grading job ids (thanks to @st-arry for creating the endpoint 🎉). Because this endpoint is guarded by admin tokens, on-demand server acts as a middle man to relay the request results.

@Xiangmingchen
Copy link
Collaborator Author

Note that the getJobStatus function used by "status" button (in details table) gets the grading job status of all jobs within the run. This is because broadway doesn't have an endpoint for querying job status for a specific job. This might cause some performance issues given that a run might have hundreds of jobs in it.

However we shouldn't try to cache the result and reuse it every time because the grading job status might change between clicks. The best way to improve this would require a new endpoint on broadway.

@Xiangmingchen Xiangmingchen requested a review from a team March 25, 2021 01:56
@Xiangmingchen
Copy link
Collaborator Author

Address #69

Copy link
Member

@ezhang887 ezhang887 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super familiar with the UI stuff but the other stuff looks good.

@Xiangmingchen Xiangmingchen merged commit 02372bb into master Mar 25, 2021
@Xiangmingchen Xiangmingchen deleted the final_grading_logs branch March 25, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants