Do not round floats in interpolate #2052
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fintelia
reviewed
Nov 9, 2023
JulianKnodt
force-pushed
the
fix_overflow
branch
2 times, most recently
from
991b276 to
09334a2
Compare
JulianKnodt
force-pushed
the
fix_overflow
branch
from
09334a2 to
0ccf865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I filed this issue in num_traits to control rounding behavior when converting:
rust-num/num-traits#296
I don't expect it to be fixed for a while if at all. This is a super hacky (but generic) way to ensure that floats aren't rounded in interpolate.
How do other methods handle this? I see a FIXME in gaussian blur so I suspect other methods currently also miss this. I can also update them, but I would have to litter the same hack in other places.
Closes #2045
cc @alucas2