Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(farbfeld): use the built-in methods to convert the bytes between different representations #2071

Merged

Conversation

0x61nas
Copy link
Contributor

@0x61nas 0x61nas commented Dec 14, 2023

I noticed that you are using the byteorder crate to convert the bytes between different representations, Which a thing can be done with the built-in methods like to_le_bytes and from_le_bytes since Rust 1.32.

So I updated the Farbfeld encoder and decoder to use them. However, we still have to depend on byteolder
crate since other encoders/decoders like webp, tga, pnm and ico using its methods, but I can work on that if this PR gets accepted.

I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to choose either at their option.

@0x61nas 0x61nas force-pushed the refactor/use-std-with-farbfeld branch from f25add8 to e89172d Compare December 14, 2023 18:49
@0x61nas 0x61nas changed the title refactor(farbfeld): use the primitive methods to convert the bytes between diffrent representations refactor(farbfeld): use the built-in methods to convert the bytes between different representations Dec 14, 2023
@0x61nas 0x61nas force-pushed the refactor/use-std-with-farbfeld branch from e89172d to fb0fec2 Compare December 14, 2023 18:50
@0x61nas 0x61nas force-pushed the refactor/use-std-with-farbfeld branch from fb0fec2 to b102b2c Compare December 14, 2023 18:56
@fintelia fintelia merged commit d970bf7 into image-rs:master Dec 15, 2023
35 checks passed
@0x61nas 0x61nas deleted the refactor/use-std-with-farbfeld branch December 15, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants