refactor(farbfeld): use the built-in methods to convert the bytes between different representations #2071
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that you are using the
byteorder
crate to convert the bytes between different representations, Which a thing can be done with the built-in methods liketo_le_bytes
andfrom_le_bytes
since Rust 1.32.So I updated the Farbfeld encoder and decoder to use them. However, we still have to depend on
byteolder
crate since other encoders/decoders like
webp
,tga
,pnm
andico
using its methods, but I can work on that if this PR gets accepted.I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to choose either at their option.