Remove unnecessary generic parameter from JpegDecoder
#2144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The author is experimenting with supporting streaming, so it's best not to make API changes that would prevent it. Therefore I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops an unnecessary PhantomData for the reader in JpegDecoder, hopefully reducing code bloat due to needing less monomorphization (I haven't actually checked).
On the flip side this makes JpegDecoder less consistent with other decoders (e.g. PngDecoder needs a generic parameter here) and if zune-jpeg ever supports streaming through standard interfaces we'll need another API break to support that.
So I'm not sure if this is a good idea or not.