Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type-safe project accessors #119

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Type-safe project accessors #119

merged 5 commits into from
Jan 17, 2024

Conversation

imashnake0
Copy link
Owner

@imashnake0 imashnake0 commented Jan 15, 2024 •
edited
Loading

Use type-safe project accessors.

Summary of changes:

  1. Type-safe project accessors.
  2. Remove testInstrumentationRunner.
  3. Updated dependencies.

Tested changes:

App builds 👍

@imashnake0 imashnake0 self-assigned this Jan 15, 2024
@imashnake0 imashnake0 added dependencies Updating dependencies gradle Changes to build files ci/cd GitHub Actions, etc labels Jan 15, 2024
@imashnake0
Copy link
Owner Author

imashnake0 commented Jan 15, 2024 •
edited
Loading

#75 fixed in #120 (?).

@imashnake0 imashnake0 added the bug Something isn't working label Jan 15, 2024
@imashnake0 imashnake0 marked this pull request as ready for review January 17, 2024 02:22
boswelja
boswelja reviewed Jan 17, 2024
View reviewed changes
gradle/libs.versions.toml Outdated Show resolved Hide resolved
uragiristereo
uragiristereo requested changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@uragiristereo uragiristereo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comments

@boswelja boswelja merged commit 60f117e into main Jan 17, 2024
1 check passed
@boswelja boswelja deleted the project-accessors branch January 17, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boswelja boswelja boswelja approved these changes

@uragiristereo uragiristereo uragiristereo approved these changes

Assignees

@imashnake0 imashnake0

Labels
bug Something isn't working ci/cd GitHub Actions, etc dependencies Updating dependencies gradle Changes to build files
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imashnake0 @boswelja @uragiristereo