New media module
#212
Closed
New media module
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boswelja
reviewed
Dec 2, 2024
| @@ -41,7 +43,7 @@ android { | |||
| buildFeatures { | |||
| compose = true | |||
| } | |||
| composeCompiler.enableStrongSkippingMode = true | |||
| composeCompiler.featureFlags = setOf(ComposeFeatureFlag.StrongSkipping) | |||
There was a problem hiding this comment.
Strong skipping is on by default now, no?
| @@ -42,6 +41,7 @@ import com.imashnake.animite.navigation.SocialRoute | |||
| import com.imashnake.animite.profile.ProfileScreen | |||
| import com.imashnake.animite.profile.dev.internal.ANILIST_AUTH_DEEPLINK | |||
| import com.imashnake.animite.social.SocialScreen | |||
| import com.imashnake.media.MediaPage | |||
There was a problem hiding this comment.
New package naming scheme?
| @@ -15,7 +15,7 @@ import androidx.compose.ui.platform.LocalContext | |||
| import com.imashnake.animite.core.ui.LocalPaddings | |||
| import com.imashnake.animite.core.ui.Paddings | |||
| import com.imashnake.animite.core.ui.rememberDefaultPaddings | |||
| import com.imashnake.animite.dev.ext.pastelize | |||
| import extensions.pastelize | |||
There was a problem hiding this comment.
This seems like an oopsie
|
|
||
| dependencies { | ||
| implementation(libs.compose.material3) | ||
| implementation(libs.androidx.coreKtx) |
There was a problem hiding this comment.
webp and scale that down, 1.45mb is huge
|
Ok messy PR lemme chunk my work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.Created a new media module since we need this code in the profile module (for navigating to media pages) => circular dependency (app <-> profile).
Summary of changes:
Tested changes: