Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groundwork for searching for Anime titles using MyAnimeList #235

Merged
merged 7 commits into from
Dec 31, 2024

Conversation

Iannnr
Copy link
Collaborator

@Iannnr Iannnr commented Dec 30, 2024

Summary of changes:

  1. Allows searching of anime details using the MyAnimeList API by setting up a base Ktor URL for any MAL network operations
  2. Redacted client ID for now as I'm not decided on if I want it to be shared, or add instructions on how users can create their own, or injects from local properties etc...
  3. Not hooked up yet to the ViewModel because I wanna create a UseCase which fetches from both AniList and MAL and returns a merged version from the DB, once we've setup Room again
  4. Doesn't currently provide any error handling, and it crashes if setup incorrectly, but I can fix that later when it's hooked up/in the UseCase
  5. The search fields are a bit superfluous, but it's an extensive list until we know what fields we want to merge when saving to local storage

Additionally

  1. Removed the unnecessary nullable field on the search query for AniList

Tested changes:

  • API does indeed work if you provide a client ID instead of redacting it
  • The response model matches the JSON Response, as the classes were generated from the JSON response

@imashnake0 imashnake0 added enhancement Enhancement feature New feature labels Dec 31, 2024
Copy link
Collaborator

@boswelja boswelja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ship it

@imashnake0 imashnake0 merged commit d25c135 into imashnake0:main Dec 31, 2024
1 check passed
@imashnake0
Copy link
Owner

shipped! ily guys :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants