Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AndroidView with Text #245

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Replace AndroidView with Text #245

merged 1 commit into from
Jan 15, 2025

Conversation

imashnake0
Copy link
Owner

Compose supports HTML parsing now (sort of). Merging this PR before making the details composable clickable to open a bottom sheet.

Summary of changes:

  1. Replaced AndroidView with Text for the media description.

Tested changes:

yep

Compose supports HTML parsing now (sort of).
@imashnake0 imashnake0 added the enhancement Enhancement label Jan 15, 2025
@imashnake0 imashnake0 self-assigned this Jan 15, 2025
@imashnake0 imashnake0 merged commit affdfc0 into main Jan 15, 2025
1 check passed
update = { it.text = html },
modifier = contentModifier
Text(
text = AnnotatedString.fromHtml(description),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now PR into compose-markdown doing this for HTML 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants