Fix RealViewsSimplifyUtils.java wrong argument order in ScaleAndTranslation constructor #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation constructor Swaps argument in ScaleAndTranslation constructor: it should be scales first and translations second.
|
Thanks @NicoKiaru |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swaps argument in ScaleAndTranslation constructor: it should be scales first and translations second.
I've noticed this because I'm trying to improve the perfs of some bigdataviewer-playground functionality. By chance I went into this branch and I obtained weird results. In debugging I found this inversion in constructor arguments. I did not checked extensively whether there was other similar inversion in the repo.