add env_file to all docker services for timezone consistency #13102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The redis container definitely isn't involved in any (user-facing) timezone stuff. I'm not all too stoked about just blanket passing all the env vars to containers that don't need them. If the Postgres container can meaningfully make use of the TZ env var then we should pass it explicitly instead. |
|
Feel free to add environment entries to specific containers but we're not going to add the env file to any other container. |
|
What do you mean re-apply? The PR was closed and we didn't add this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds env_file to all Docker containers to ensure timezone settings are consistent throughout the stack. By centralizing the environment configurations, we avoid any potential issues caused by mismatched timezones between services.