Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Encode db dump in UTF-8 without BOM for Windows #13775

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chore(docs): Encode db dump in UTF-8 without BOM for Windows #13775

merged 1 commit into from
Nov 13, 2024

Conversation

amorphobia
Copy link
Contributor

Related to #11787

On Windows, the encoding “utf8” actually means “UTF-8 with BOM”. What we need is “utf8NoBOM”. However it’s not available from the Windows 10 built-in PowerShell.

This change suggests WriteAllLines function from the pre-installed .net framework, which uses real UTF-8 encoding by default.

https://learn.microsoft.com/en-us/dotnet/api/system.io.file.writealllines?view=netframework-4.6

The default behavior of the WriteAllLines(String, IEnumerable) method is to write out data by using UTF-8 encoding without a byte order mark (BOM).

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 28, 2024
@NicholasFlamy
Copy link
Member

It works, but I don't understand the need for it. Please enlighten me.

@amorphobia
Copy link
Contributor Author

The previous PR #11787 said

Powershell does not use UTF-8 encoding by default, which makes database dumps incompatible between Windows and Linux. This PR makes Windows save the dump in UTF-8 format.

And UTF-8 without BOM is the de facto encoding in Linux. Some software may not handle BOM well. Just in case BOM-less is really needed.

I personally do not have preference on BOM. It's up to the maintainers.

@NicholasFlamy
Copy link
Member

UTF-8 without BOM is the de facto encoding in Linux. Some software may not handle BOM well. Just in case BOM-less is really needed.

I presume the Automatic backups as well as the manual Linux backups save to this format as well so I take it that having the manual Windows backup save in this format makes sense.

NicholasFlamy
NicholasFlamy approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@NicholasFlamy NicholasFlamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the command. It does work. LGTM

@zackpollard
Copy link
Contributor

LGTM, thanks for the change and the explanation!

@zackpollard zackpollard merged commit ecb8349 into immich-app:main Nov 13, 2024
33 checks passed
@amorphobia amorphobia deleted the WinUTF8 branch November 13, 2024 10:33
bdavis2-PCTY pushed a commit to bdavis2-PCTY/immich that referenced this pull request Nov 18, 2024
@amorphobia @bdavis2-PCTY
chore(docs): encode db dump in UTF-8 without BOM for Windows (immich-…
574393d 
…app#13775)
bdavis2-PCTY added a commit to bdavis2-PCTY/immich that referenced this pull request Nov 18, 2024
@bdavis2-PCTY @jrasm91
@danieldietzler @mertalev @zackpollard @renovate @darrelhong @dotlambda @bo0tzz @Sweebah @github-actions @alextran1502 @yozik04 @aviv926 @weblate @amirulasri @betrion @dosten @flokuep @hexiejexie @bunubbv @leocb @LeonardoCasarotto @Linerly @heavygale @NightMean @medolino2009 @papuass @anonymaew @rveciana @tux2000 @made-in-Chuguev @ITestInProd @MickLesk @dvbthien @alangrainger @yashrajjain726 @C-Otto @michelheusschen @benmccann @cfitzw @Pranay-Pandey @shenlong-tanwen @mmomjian @Beetix @carldressler @icecore2 @Fjuro @Hurricane-32 @Iwwww @JohnGrubba @mncam @julpoppi @rastos @samex @indam @TheGothian @fmis13 @pyccl @waclaw66 @xxzp3 @Eee14 @slamp @thariq-shanavas @yodatak @Scrumplex @zhaoterryy @ben-basten @mcarbonne @Snowknight26 @Mraedis @gamescom15 @dependabot @amorphobia @p2kmgcl @NicholasFlamy @johnstef99 @Lukasdotcom @duckimann @IMBeniamin @Tiefseetauchner @weathondev
Backmerge (#1)
c2c3109 
* feat: track when assets are added to an album (immich-app#13725)

* refactor(server): telemetry env variables (immich-app#13705)

refactor(server)!: telemetry env variables

Co-authored-by: Mert <[email protected]>

* refactor(server): database config (immich-app#13730)

* refactor(server): user create logic (immich-app#13728)

* fix: duplicated library scan jobs and api server library watch (immich-app#13734)

* chore(deps): update base-image to v20241025 (major) (immich-app#13736)

chore(deps): update base-image to v20241025

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: X years ago ordering (immich-app#13742)

* fix: order by fileCreatedAt to account for tz

* run make sql

* chore(ml): remove setuptools from dependencies (immich-app#13762)

* feat: github actions workflow to fix formatting (immich-app#13768)

* fix: Add DB_DATA_LOCATION config. (immich-app#13754)

Add DB_DATA_LOCATION config.

Posted [on reddit](https://www.reddit.com/r/unRAID/comments/1f8wq45/immich_install_via_docker_compose_database_cannot/).

* chore: version v1.119.0

* chore(mobile): post release task (immich-app#13779)

* feat(web): add job action to search page result (immich-app#13784)

* chore(deps): update dependency @types/node to ^20.17.0 (immich-app#13787)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update stumpylog/image-cleaner-action action to v0.9.0 (immich-app#13788)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* docs: note about Nginx reverse proxy compatibility with Let's Encrypt (immich-app#13764)

* Nginx reverse proxy compatibility with Let's Encrypt

* Update reverse-proxy.md

* Update reverse-proxy.md

Co-authored-by: bo0tzz <[email protected]>

* Priority of = is higher

* Update reverse-proxy.md

---------

Co-authored-by: bo0tzz <[email protected]>

* docs: Add info about album sync&folder view (immich-app#12371)

* Album Sync

* npm run format:fix

* fix path

* info about folder view

* Sync albums

* npm run format:fix

* Add information about limitations of a property that appears in multiple albums

* npm run format:fix

* - to ->

* Update docs/docs/features/mobile-app.mdx

Co-authored-by: Daniel Dietzler <[email protected]>

* Update docs/docs/features/mobile-app.mdx

Co-authored-by: Daniel Dietzler <[email protected]>

---------

Co-authored-by: Alex <[email protected]>
Co-authored-by: Daniel Dietzler <[email protected]>

* chore: version v1.119.1

* fix(server): handle N/A duration response from ffprobe (immich-app#13803)

* chore(web): update translations (immich-app#13688)

Translate-URL: https://hosted.weblate.org/projects/immich/immich/ca/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/de/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/en_devel/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/es/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/et/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/fi/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/hr/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/id/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/it/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/ko/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/lv/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/ms/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/pt_BR/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/ro/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/ru/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/sk/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/sr_Cyrl/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/sr_Latn/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/sv/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/th/
Translate-URL: https://hosted.weblate.org/projects/immich/immich/uk/
Translation: Immich/immich

Co-authored-by: Amirul Asri <[email protected]>
Co-authored-by: Dean Cvjetanović <[email protected]>
Co-authored-by: Diego Saint Esteben <[email protected]>
Co-authored-by: Florian Ostertag <[email protected]>
Co-authored-by: Hexie <[email protected]>
Co-authored-by: Indrek Haav <[email protected]>
Co-authored-by: Jiri Grönroos <[email protected]>
Co-authored-by: Junghyuk Kwon <[email protected]>
Co-authored-by: Lab Forensic <[email protected]>
Co-authored-by: Leo Bottaro <[email protected]>
Co-authored-by: LeonardoCasarotto <[email protected]>
Co-authored-by: Linerly <[email protected]>
Co-authored-by: Max <[email protected]>
Co-authored-by: Michal Micech <[email protected]>
Co-authored-by: Miki Mrvos <[email protected]>
Co-authored-by: Mārtiņš Bruņenieks <[email protected]>
Co-authored-by: Napat Srichan <[email protected]>
Co-authored-by: Roger Veciana Rovira <[email protected]>
Co-authored-by: gallegonovato <[email protected]>
Co-authored-by: qtm <[email protected]>
Co-authored-by: tux2000 <[email protected]>
Co-authored-by: Вячеслав Лукьяненко <[email protected]>

* feat: mount checks on a folder level (immich-app#13801)

* fix: shutdown api process when another worker exits unexpectedly (immich-app#13802)

* refactor: better postgres connection param typing (immich-app#13800)

* fix(mobile): Revert thumbnail image ui improvements  (immich-app#13655) (immich-app#13806)

Revert "chore(mobile): thumbnail image ui improvements  (immich-app#13655)"

This reverts commit 16f2364.

* refactor(server): worker cleanup (immich-app#13805)

* feat(web): library settings crontab link includes existing expression (immich-app#13807)

* fix(server): keep system config transformations (immich-app#13796)

* chore(docs): add feature to readme (immich-app#13794)

* fix(mobile): thumbnail not filled area on tablet (immich-app#13808)

* feat(web): disable opening image and library sub-items by default (immich-app#13729)

Disable opening image and library sub-items by default

Disable both the Image Settings and the External Library sub-items by default. This aligns with auth other settings sub-items showing as collapsed by default.

* chore(server): telemetry env clean up (immich-app#13813)

* refactor(server): cls (immich-app#13814)

* refactor(server): env validation (immich-app#13817)

* chore(deps): update grafana/grafana docker tag to v11.3.0 (immich-app#13763)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update terraform cloudflare to v4.45.0 (immich-app#13820)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update base-image to v20241029 (major) (immich-app#13821)

chore(deps): update base-image to v20241029

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(web): scrubber label and animation (immich-app#13815)

* feat(web): scrubber label and animation

* tune x fly in distance

* refactor

* lint and minor fix

* fly height

* chore(docs): update german readme to latest version (immich-app#13824)

* chore(docs): update german readme to latest version

* formatting

* chore(deps): update node to v22 (major) (immich-app#13792)

* chore(deps): update node to v22

* fix: deprecated constructor

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Dietzler <[email protected]>

* fix(deps): update machine-learning (immich-app#13786)

* refactor(server): remove unused on method (immich-app#13830)

* chore(deps): update typescript-projects (immich-app#13789)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(mobile): search page (immich-app#13833)

* fix(mobile): search page minor problems

* fix: flashing between search

* restore search size

* remove print statement

* linting

* fix(mobile): Reapply thumbnail image improvements and fix issue immich-app#13804 (immich-app#13835)

fix issue immich-app#13804

Co-authored-by: dvbthien <[email protected]>

* feat: built-in automatic database backups (immich-app#13773)

* chore(deps): update dependency @types/node to ^22.8.1 (immich-app#13854)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency node to v22 (immich-app#13855)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(mobile): not throwing error when cannot parse orientation value (immich-app#13853)

* fix(mobile): not throw when error in parsing the orientation

* fix(mobile): not throw when error in parsing the orientation

* linting

* chore: move library settings cron expression to setting select element (immich-app#13856)

* chore(docs): Add Immich Public Proxy to the Community Projects list (immich-app#13836)

Update community-projects.tsx

Add Immich Public Proxy to Community Projects

* refactor(server): job discovery (immich-app#13838)

refactor(server): job discorvery

* chore(deps): update flutter (immich-app#13455)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(mobile): update flutter_web_auth (immich-app#13863)

* feat(server): use tonemapx for software tone-mapping (immich-app#13785)

* fix(mobile): do not removed not backup asset when selecting the correspond options (immich-app#13256)

* fixed the local ids selecting issue

* code: updated impl inside deleteLocalOnlyAssets

* fix: used png instead of jpg to maintain picture quality

* Revert "fix: used png instead of jpg to maintain picture quality"

This reverts commit 04f2ed5.

* fix: update logic from code-review perspective

* refractor (mobile) : Dart fix applied

* fix (mobile) : Updated multi grid as per requirement

---------

Co-authored-by: Alex <[email protected]>

* fix(server): wrong image dimensions for RAW files (RAF, CR2) (also fixes face preview) (immich-app#13377)

* refactor(server): immich worker (immich-app#13871)

refactor(server): immich work

* chore: svelte 5 🎉  (immich-app#13738)

chore: svelte 5

Co-authored-by: Michel Heusschen <[email protected]>
Co-authored-by: Ben McCann <[email protected]>

* feat: render asset path (immich-app#13873)

render asset path

* fix: healthcheck if custom host is set (immich-app#13887)

* fix(deps): update dependency exiftool-vendored to v28.7.0 (immich-app#13790)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: remove duplicateIds on unique assets (immich-app#13752)

* fix(deps): update machine-learning (immich-app#13919)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update node (immich-app#13918)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @types/node to ^22.8.5 (immich-app#13923)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* refactor(server): get worker (immich-app#13927)

* chore: better observability for geodata import (immich-app#13931)

* refactor: config init event for first config load (immich-app#13930)

* chore(mobile): upgrade gradle (immich-app#13901)

* chore(mobile): upgrade gradle

* update photo_manager

* migrate from kapt to ksp

pumps kotlin and other dependency version to fix build issues

* increase java heap size

---------

Co-authored-by: shenlong-tanwen <[email protected]>

* chore(web): scrubber animation (immich-app#13936)

* chore(web): scrubber animation

* minor styling

* chore(deps): update dependency @types/node to ^22.8.6 (immich-app#13937)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update typescript-projects (immich-app#13922)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Dietzler <[email protected]>

* chore(deps): update base-image to v20241105 (major) (immich-app#13826)

* docs: fail2ban community project (immich-app#13943)

fail2ban

* chore(mobile): translation update (immich-app#13942)

* chore(web): update translations (immich-app#13810)

Co-authored-by: Benjamin Freeman <[email protected]>
Co-authored-by: Bezruchenko Simon <[email protected]>
Co-authored-by: Carl Dressler <[email protected]>
Co-authored-by: Diego Saint Esteben <[email protected]>
Co-authored-by: Dmitry Banny <[email protected]>
Co-authored-by: Dragonslayer <[email protected]>
Co-authored-by: Fjuro <[email protected]>
Co-authored-by: Florian Ostertag <[email protected]>
Co-authored-by: Hurricane-32 <[email protected]>
Co-authored-by: Indrek Haav <[email protected]>
Co-authored-by: Iwwww <[email protected]>
Co-authored-by: JBP <[email protected]>
Co-authored-by: Jonas Grubbauer <[email protected]>
Co-authored-by: Junghyuk Kwon <[email protected]>
Co-authored-by: Kamil Warczek <[email protected]>
Co-authored-by: Kovács Ádám <[email protected]>
Co-authored-by: Linerly <[email protected]>
Co-authored-by: Mehmet Numan Çam <[email protected]>
Co-authored-by: Miki Mrvos <[email protected]>
Co-authored-by: Polly Julien <[email protected]>
Co-authored-by: Rastislav Simcisko <[email protected]>
Co-authored-by: Samet Güzeldemirci <[email protected]>
Co-authored-by: Shawn <[email protected]>
Co-authored-by: Stan P <[email protected]>
Co-authored-by: T.Nikolaou <[email protected]>
Co-authored-by: TheGothian <[email protected]>
Co-authored-by: fmis13 <[email protected]>
Co-authored-by: pyccl <[email protected]>
Co-authored-by: qtm <[email protected]>
Co-authored-by: vytautas <[email protected]>
Co-authored-by: waclaw66 <[email protected]>
Co-authored-by: xxzp3 <[email protected]>
Co-authored-by: Вячеслав Лукьяненко <[email protected]>
Co-authored-by: 李奕寯 <[email protected]>

* chore: version v1.120.0

* fix: docker link (immich-app#13956)

* docs: improve custom-locations wording to be easier to read (immich-app#13849)

* Improve wording to make it easier to read custom-locations.md

It's only grammatical change

* Update docs/docs/guides/custom-locations.md

Co-authored-by: bo0tzz <[email protected]>

* Update custom-locations.md

Revert to 'because of' and remove 'hard drive'

---------

Co-authored-by: bo0tzz <[email protected]>

* docs: Added a note about avoiding redundant database backups (immich-app#13958)

* Add note about built-in backups

* npm run format:fix

* fix(server): cannot render email template (immich-app#13957)

* chore: tidy up backup-and-restore.md (immich-app#13961)

* docs: 50k stars (immich-app#13964)

* chore(mobile): post release task (immich-app#13954)

* docs: add backups to startup folders list (immich-app#13967)

Add the check of backups that is done on immich microservice of backups folder presence

* fix(server): allow starting backup through API and fix pg_dumpall args when using database URLs (immich-app#13970)

* fix(server): allow starting backup through API

* fix(server): fix pg_dumpall args when using database URLs

The database has to be specified using `-d`, unlike for pg_dump.

* fix(server): database backups compatible with deduplication (immich-app#13965)

gzip --rsyncable has a slightly worse compression ratio, but allows for
efficient deduplication and, as the name implies, faster rsync
operations.

Signed-off-by: Sefa Eyeoglu <[email protected]>

* docs: update roadmap (immich-app#13984)

* fix(mobile): video player not playing in full size on Android (immich-app#13986)

* fix(web): time zone dependent test (immich-app#13859)

* chore: version v1.120.1

* chore(mobile): update isar build (immich-app#13987)

* refactor: remove smart info table (immich-app#13985)

* chore(mobile): post release tasks (immich-app#13989)

* refactor(server): cron repository (immich-app#13988)

* refactor(server): cron validation (immich-app#13990)

* chore: backups custom location and config file docs (immich-app#13996)

* fix(server): support non-default postgres port when taking a backup (immich-app#13992)

* fix(server): thumbnail rotation when using embedded previews (immich-app#13948)

* docs: make IGNORE_MOUNT_CHECK warning stronger (immich-app#14011)

* fix(web): use locale for scrubber label when scrolling (immich-app#14012)

* chore(docs): roadmap SEO (immich-app#14024)

* fix(mobile): make sure date locale is inititialized for some languages (immich-app#14035)

* feat(web): stable json settings export (immich-app#14036)

* recursively sort json output (settings)

* fix format/lint/...g

* chore(web): Update the new version announcement text (immich-app#14001)

* Update en.json

* Update en.json

* Update en.json

* docs: Fix DCM docs link (immich-app#14059)

Fix DCM docs link

* chore: add weblate requests (immich-app#14051)

* docs: clarify file size impact in hardware-transcoding.md (immich-app#14049)

* fix(server): attempt to delete failed backups immediately after failure (immich-app#13995)

* docs: backup folder name is backups (immich-app#14073)

* fix: config updates not applying for job and storage template service (immich-app#14074)

* chore(ml): replace fastapi-slim with fastapi (immich-app#14091)

The two have been identical since version 0.112.0:
fastapi/fastapi#11525 (comment)

* chore(deps): update node (immich-app#14090)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update base-image to v20241112 (major) (immich-app#14088)

chore(deps): update base-image to v20241112

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* feat(server): use pg_dumpall version that matches the database version (immich-app#14083)

* fix(server): correct rotation for common files (immich-app#14092)

* fix(server): correct rotation for common files

* fix: test:

* pr feedback

* fix(server): backup version checks not handling database versions correctly (immich-app#14102)

* chore: version v1.120.2

* chore(mobile): post release tasks (immich-app#14105)

* chore(deps): update redis:6.2-alpine docker digest to 77c6e37 (immich-app#14098)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update docker.io/redis:6.2-alpine docker digest to 77c6e37 (immich-app#14097)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): bump ytanikin/PRConventionalCommits from 1.2.0 to 1.3.0 (immich-app#13051)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore(deps): update prom/prometheus docker digest to 2659f4c (immich-app#13928)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* refactor(mobile): video controls (immich-app#14086)

* refactor video controls

* inline

* make mute icon const

* move placeholder to private widget

* adjust text width, move volume button slightly right

* chore(docs): encode db dump in UTF-8 without BOM for Windows (immich-app#13775)

* chore(deps): update docker.io/redis:6.2-alpine docker digest to eaba718 (immich-app#14113)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update redis:6.2-alpine docker digest to eaba718 (immich-app#14114)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(mobile): duration ui overflow (immich-app#14120)

* fix(mobile): duration ui overflow

* pr feedback

* feat: use dateTimeOriginal to calculate album date (immich-app#14119)

* docs: Update TrueNAS docs for TrueNAS SCALE 24.10 (immich-app#14067)

* initial-docs-update

* add-info-about-external-libraries

* fix(mobile): fix logout timeout (immich-app#14104)

* fix(mobile): add timeout to logout

* chore(mobile): refactor timeout durations

* feat(mobile): add loading state to logout button

* chore(mobile): format authentication.provider.dart

* chore: format

* chore: revert settings.json change

---------

Co-authored-by: Alex <[email protected]>

* feat: add minimal devcontainer setup (immich-app#14038)

* add minimal devcontainer setup

* fix Makefile & update doc

* fix Makefile

* add warning regarding devcontainer + add newline at EOF

* feat(mobile): new video slider ui (immich-app#14126)

* fix(server): Some MTS videos fail to generate thumbnail (immich-app#14134)

* Stop skipping of all frames in MTS video

* Only skip flag for mts videos

* Fix lint checks

* Adds test

* Add comment for why flag is removed

* chore(web): migration svelte 5 syntax (immich-app#13883)

* fix(web): textarea autogrow height (immich-app#13983)

fix(web): remove album assetGridWidth & globalWidth

Co-authored-by: Alex Tran <[email protected]>

* fix: Routing back button in sharedLinks page (immich-app#13703)

* fix: go back to last page from shared links page. Handle albums page from shared links page routing

* add default route for sharing

* chore: remove redundant import

* remove unnecessary comment

---------

Co-authored-by: Alex Tran <[email protected]>

* fix(web): ensure current asset index stays within bounds (immich-app#14013)

* fix(web): saving pasted coordinates (immich-app#14143)

* chore(web): move enum out of .svelte file (immich-app#14144)

* chore(web): clean up todo task

* chore(web): move enums out of .svelte file

* fix(web): update description height when navigating between assets (immich-app#14145)

* fix(web): allow selecting people after clearing search options (immich-app#14146)

* fix(mobile): Android local notification failes to invoke (immich-app#14155)

* fix(mobile): local notification failed to invoke

* add proguard rules

* feat(web): Added tag button to the context menu in the favorites page (immich-app#14156)

Added tag action to the context menu in the favorites page when selection is active

* chore(deps): update prom/prometheus docker digest to 3b9b2a1 (immich-app#14154)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(web): prevent infinite loop when modifying stacked asset (immich-app#14162)

* fix(cli): Concurrency not fully using queue potential (immich-app#11828)

* refactor(mobile): backup info box (immich-app#14171)

split up backup info box into separate widgets

* refactor(web): remove reactivity triggers (immich-app#14164)

* fix(web): don't refresh panorama viewer when modifying asset (immich-app#14163)

* feat: adding photo & video storage space to server stats (immich-app#14125)

* expose detailed user storage stats + display them in the storage per user table

* chore: openapi & sql

* fix: fix test stubs

* fix: formatting errors, e2e test and server test

* fix: upper lower case typo in spec file

---------

Co-authored-by: Alex Tran <[email protected]>

* docs: get asset owner by ID from database (immich-app#14174)

asset owner

* fix(mobile): unnecessary rebuilds from partner share notifier (immich-app#14170)

* fix unnecessary notifications

* move equality function

* sort by id

* use same comparison for initial and later queries

* fix: show tags when viewing stacked assets (immich-app#14199)

fix: refresh tags when viewing stacked assets

* chore(deps): pin mcr.microsoft.com/devcontainers/typescript-node docker tag to dc2c365 (immich-app#14124)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(mobile): use sets in album refresh, concurrent futures (immich-app#14193)

* use sets in album sync, concurrent futures

* batch excluded asset IDs

* update test

* take advantage of sets in Recents check

* move log statement

* smaller diff

* fix(mobile): Dismissible menus (immich-app#14192)

* chore(mobile): make all search filters dismissible

* chore(mobile): make ImmichAppBarDialog dismissible

---------

Co-authored-by: Alex <[email protected]>

---------

Signed-off-by: Sefa Eyeoglu <[email protected]>
Co-authored-by: Jason Rasmussen <[email protected]>
Co-authored-by: Daniel Dietzler <[email protected]>
Co-authored-by: Mert <[email protected]>
Co-authored-by: Zack Pollard <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Darrel <[email protected]>
Co-authored-by: Robert Schütz <[email protected]>
Co-authored-by: bo0tzz <[email protected]>
Co-authored-by: Sweebah <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Alex <[email protected]>
Co-authored-by: Jevgeni Kiski <[email protected]>
Co-authored-by: aviv926 <[email protected]>
Co-authored-by: Weblate (bot) <[email protected]>
Co-authored-by: Amirul Asri <[email protected]>
Co-authored-by: Dean Cvjetanović <[email protected]>
Co-authored-by: Diego Saint Esteben <[email protected]>
Co-authored-by: Florian Ostertag <[email protected]>
Co-authored-by: Hexie <[email protected]>
Co-authored-by: Indrek Haav <[email protected]>
Co-authored-by: Jiri Grönroos <[email protected]>
Co-authored-by: Junghyuk Kwon <[email protected]>
Co-authored-by: Lab Forensic <[email protected]>
Co-authored-by: Leo Bottaro <[email protected]>
Co-authored-by: LeonardoCasarotto <[email protected]>
Co-authored-by: Linerly <[email protected]>
Co-authored-by: Max <[email protected]>
Co-authored-by: Michal Micech <[email protected]>
Co-authored-by: Miki Mrvos <[email protected]>
Co-authored-by: Mārtiņš Bruņenieks <[email protected]>
Co-authored-by: Napat Srichan <[email protected]>
Co-authored-by: Roger Veciana Rovira <[email protected]>
Co-authored-by: gallegonovato <[email protected]>
Co-authored-by: qtm <[email protected]>
Co-authored-by: tux2000 <[email protected]>
Co-authored-by: Вячеслав Лукьяненко <[email protected]>
Co-authored-by: Justin <[email protected]>
Co-authored-by: CanbiZ <[email protected]>
Co-authored-by: Daniel Dietzler <[email protected]>
Co-authored-by: dvbthien <[email protected]>
Co-authored-by: dvbthien <[email protected]>
Co-authored-by: Alan Grainger <[email protected]>
Co-authored-by: Yashraj Jain <[email protected]>
Co-authored-by: Carsten Otto <[email protected]>
Co-authored-by: Michel Heusschen <[email protected]>
Co-authored-by: Ben McCann <[email protected]>
Co-authored-by: cfitzw <[email protected]>
Co-authored-by: Pranay Pandey <[email protected]>
Co-authored-by: shenlong-tanwen <[email protected]>
Co-authored-by: Matthew Momjian <[email protected]>
Co-authored-by: Benjamin Freeman <[email protected]>
Co-authored-by: Bezruchenko Simon <[email protected]>
Co-authored-by: Carl Dressler <[email protected]>
Co-authored-by: Dmitry Banny <[email protected]>
Co-authored-by: Dragonslayer <[email protected]>
Co-authored-by: Fjuro <[email protected]>
Co-authored-by: Hurricane-32 <[email protected]>
Co-authored-by: Iwwww <[email protected]>
Co-authored-by: JBP <[email protected]>
Co-authored-by: Jonas Grubbauer <[email protected]>
Co-authored-by: Kamil Warczek <[email protected]>
Co-authored-by: Kovács Ádám <[email protected]>
Co-authored-by: Mehmet Numan Çam <[email protected]>
Co-authored-by: Polly Julien <[email protected]>
Co-authored-by: Rastislav Simcisko <[email protected]>
Co-authored-by: Samet Güzeldemirci <[email protected]>
Co-authored-by: Shawn <[email protected]>
Co-authored-by: Stan P <[email protected]>
Co-authored-by: T.Nikolaou <[email protected]>
Co-authored-by: TheGothian <[email protected]>
Co-authored-by: fmis13 <[email protected]>
Co-authored-by: pyccl <[email protected]>
Co-authored-by: vytautas <[email protected]>
Co-authored-by: waclaw66 <[email protected]>
Co-authored-by: xxzp3 <[email protected]>
Co-authored-by: 李奕寯 <[email protected]>
Co-authored-by: slamp <[email protected]>
Co-authored-by: Thariq Shanavas <[email protected]>
Co-authored-by: yodatak <[email protected]>
Co-authored-by: Sefa Eyeoglu <[email protected]>
Co-authored-by: Terry Zhao <[email protected]>
Co-authored-by: Ben <[email protected]>
Co-authored-by: mcarbonne <[email protected]>
Co-authored-by: Snowknight26 <[email protected]>
Co-authored-by: Joren Guillaume <[email protected]>
Co-authored-by: gamescom15 <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xuesong <[email protected]>
Co-authored-by: Pablo Molina <[email protected]>
Co-authored-by: Nicholas Flamy <[email protected]>
Co-authored-by: John Stef <[email protected]>
Co-authored-by: Lukas <[email protected]>
Co-authored-by: Đức <[email protected]>
Co-authored-by: Ben <[email protected]>
Co-authored-by: Lena Tauchner <[email protected]>
Co-authored-by: weathondev <[email protected]>
yosit pushed a commit to yosit/immich that referenced this pull request Nov 21, 2024
@amorphobia @yosit
chore(docs): encode db dump in UTF-8 without BOM for Windows (immich-…
24639f5 
…app#13775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasFlamy NicholasFlamy NicholasFlamy approved these changes

@zackpollard zackpollard zackpollard approved these changes

Assignees
No one assigned
Labels
changelog:documentation documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amorphobia @NicholasFlamy @zackpollard @danieldietzler