Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): specify names for thumbnail files #14425

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

eligao
Copy link
Contributor

@eligao eligao commented Dec 1, 2024

This change specified a file name for thumbnail files when saved via right click - "Save image as..."
The saved file name will be suffixed with its AssetMediaSize to prevent confusing with the original file.
e.g:

  • IMG_0001.jpg -> IMG_0001_preview.jpg
  • IMG_0002.dng -> IMG_0002_preview.jpg

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix the formatting and test issues

@alextran1502 alextran1502 merged commit 4eb7758 into immich-app:main Dec 1, 2024
33 checks passed
@eligao eligao deleted the feat/preview-filename branch December 1, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants