refactor(server): use exiftool for file date metadata #16453
+82
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertalev
force-pushed
the
refactor/server-remove-metadata-extraction-stat-calls
branch
from
b3615aa to
f394c7d
Compare
mertalev
force-pushed
the
refactor/server-remove-metadata-extraction-stat-calls
branch
from
ba670be to
0f8e67f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are two redundant
statcalls in metadata extraction that can instead use the exiftool output (tags starting withFileare from the file system). Besides generally less file IO, it avoids taking up a thread (or waiting to acquire one) in the all-too-limited libuv threadpool. Based on #16450, which should be merged first.I tested locally and it works as expected. However, there are cases in the library E2E tests where the tags are undefined. I don't know why this is. The PR falls back to calling
.statin this case to handle this.This is the last of the PRs split off from #14277.