vlmcsd: add UCI support for vlmcsd #1475
Open
+80
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AutoCONFIG
force-pushed
the
master
branch
4 times, most recently
from
d2319c3 to
04cce7c
Compare
This was referenced Feb 4, 2025
1715173329
reviewed
Feb 8, 2025
1715173329
reviewed
Feb 8, 2025
- Derived from luci-app-vlmcsd with some modifications. The source code of luci-app-vlmcsd needs to be re-modified for adaptation. - Removed the listening option for 0.0.0.0:1688 because [::]:1688 can achieve dual-stack listening for both IPv4 and IPv6. - Added an option to allow Internet access, enabling users to decide whether to expose the service to the Internet on their own. - Modified the init file to meet the standards of OpenWrt init files. Signed-off-by: Yun Wang <[email protected]>
|
已更正：
|
1715173329
reviewed
Feb 9, 2025
| config_get_bool internet_access "config" "internet_access" "0" | ||
|
|
||
| if [ "$enabled" -eq "0" ];then | ||
| if [ -f "$DNSMASQ_VLMCSD" ];then |
There was a problem hiding this comment.
这里没必要，可以用
reload_service() {
stop
start
}
这样 reload 的时候就会执行 stop_service 函数。
1715173329
reviewed
Feb 9, 2025
Comment on lines
+30
to
+31
| HOSTNAME=$(uci get system.@system[0].hostname) | ||
| echo "srv-host=_vlmcs._tcp,$HOSTNAME,1688,0,100" > $DNSMASQ_VLMCSD |
There was a problem hiding this comment.
Suggested change
| HOSTNAME=$(uci get system.@system[0].hostname) | |
| echo "srv-host=_vlmcs._tcp,$HOSTNAME,1688,0,100" > $DNSMASQ_VLMCSD | |
| hostname="$(uci -q get system.@system[0].hostname)" | |
| echo "srv-host=_vlmcs._tcp,$hostname,1688,0,100" > "$DNSMASQ_VLMCSD" |
非全局变量建议用小写。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原本的vlmcsd以及luci-app-vlmcsd比较混乱，特别是init文件和uci支持是通过luci应用来实现的，而非后端程序。
所以重做调整，并使用js重写其luci应用