Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: volume size errors #103

Merged
merged 3 commits into from
Sep 5, 2024
Merged

fix: volume size errors #103

merged 3 commits into from
Sep 5, 2024

Conversation

alexanderbira
Copy link
Member

  • Impaas uses nginx, we can't control
  • Nginx will sometimes block requests, for example, when the request body is too large (>1MB)
  • This PR handles unexpected errors caused by nginx blocking these requests by:
    • Doing a client-side check for file size before running a form action
    • Appropriately handling undefined responses from server actions

matalex412
matalex412 reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@matalex412 matalex412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one small thing

components/forms/FormWithAction.tsx Outdated Show resolved Hide resolved
@alexanderbira alexanderbira merged commit 5bb11e1 into main Sep 5, 2024
4 checks passed
@alexanderbira alexanderbira deleted the fix-volume-size-errors branch September 5, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matalex412 matalex412 matalex412 approved these changes

@IlliaDerevianko IlliaDerevianko Awaiting requested review from IlliaDerevianko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderbira @matalex412