[Fix] order: ensure arcane imports do not cause undefined behavior
#3128
+259
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xunnamius
changed the title
order: ensure arcane imports do not cause undefined behaviororder: ensure arcane imports do not cause undefined behavior
…a `sortTypesAmongThemselves` Closes import-js#2912 import-js#2347 import-js#2441 Subsumes import-js#2615
Xunnamius
force-pushed
the
contrib-nan-bugfix
branch
from
d929108 to
400fb1a
Compare
ljharb
reviewed
Dec 31, 2024
src/rules/order.js
Outdated
Comment on lines
530
to
533
| if (rank === undefined) { | ||
| rank = ranks.groups[impType]; | ||
|
|
||
| if(rank === undefined) { |
There was a problem hiding this comment.
Suggested change
| if (rank === undefined) { | |
| rank = ranks.groups[impType]; | |
| if(rank === undefined) { | |
| if (typeof rank === 'undefined') { | |
| rank = ranks.groups[impType]; | |
| if (typeof rank === 'undefined') { |
There was a problem hiding this comment.
I hoped I could factor this change out from contrib-sort-types-among-themselves, but I've noticed the test needs sortTypesGroup to trigger the bad behavior :)
Xunnamius
force-pushed
the
contrib-nan-bugfix
branch
from
853d7b6 to
321c79c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3127
This PR implements in
import/order: a fix to ensureNaNis never passed into rank-computing functions, which can result in undefined behavior.A demo package containing this fix is temporarily available for easy testing:
Ensure strange imports do not cause strange behavior
There are certain edge cases where a
NaNrank gets passed around, such as using an import with an absolute specifier under certain configurations. The fix concerns thecomputeRankfunction.This PR includes a unit test to catch potential regressions.