You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue is linked to issue #105, and BNF-EN importer is also concerned.
For all 3 importer, iiif_link contains the link to the JPG image itself.
The placement of iiif_link and c in the content items fileds is inconsistent accross importers.
While iiif_link is expected to be in the subfield m by the rebuilder [see here], it's not the case for the coordinates c which are expected to be ouside of the subfield.
As a result, the placements of the subfields were uniformized to fit the requirements of the rebuilder for now, and will be corrected along with the rebuilder so that each module (and importer) can be tested independently first.
This correction should take place BEFORE a reingestion of the data corresponding to the concerned importers (BNF, BNF-EN, RERO).
There are two problems here:
iiif_link
should contain the link to JSON manifest, not to the JPG image itself;c
is missing for content items of typeimage
(e.g.excelsior-1910-11-16-a-i0161
).Both problems will break the
impress-pyimages
script that downloads images via IIIF, cfr. https://github.com/impresso/impresso-images/blob/89bef72675f4bd9ea9a7557cbbadcf337c61a0bf/impresso-pyimages/impresso_images/data_utils.py#L62Original JSON:
Expected JSON:
The text was updated successfully, but these errors were encountered: