Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better views implementation #12

Merged
merged 28 commits into from
Dec 21, 2023
Merged

Better views implementation #12

merged 28 commits into from
Dec 21, 2023

Conversation

imrn99
Copy link
Owner

@imrn99 imrn99 commented Dec 21, 2023 •
edited
Loading

  • Replaced internal Vec of views by a custome structure, ViewData
  • updated all interfaces accordingly
  • Removed DataType enum; the Rust ownership system coupled with explicit mirroring will be enough
  • doc update

imrn99 added 28 commits December 20, 2023 15:30
@imrn99
refactor: Renamed ViewBase into View
5c11e2c
@imrn99
refactor: removed type aliases for view variants
3318d77 
ViewRO / ViewRW / mirror functions that returned those
@imrn99
refactor: removed last type alias ViewOwned
b563c24
@imrn99
docs: updated doc accordingly to aliases deletion
2467f5b
@imrn99
refactor: removed DataType enum from View implementation
4e43a21
@imrn99
feat: impl PartialEq for View
c51380f
@imrn99
refactor: delete DataType enum
6f108e4
@imrn99
feat: MemorySpace enum
2bf44b1
@imrn99
refactor: rename Layout as MemoryLayout
509712b 
Layout is already used in the standard/core lib
@imrn99
feature: allocation method for view data
a6c007f
@imrn99
feature: add ViewData type
72bdf65 
this should eventually replace the vector inside of views
@imrn99
feature: more methods for ViewData
ef76f45
@imrn99
refactor: isize -> usize in ViewData methods
b54e814
@imrn99
feat: add mirror field to ViewData struct
b68a68a 
this can be used to easily handle mirrors & ensure the memory space
is deallocated only once
@imrn99
feeat: add take_vals method & ensure initialization of ViewData
64e2f00
@imrn99
fix: revert init addition in ViewData::new
46c2e1e
@imrn99
fix: correct inconsistent signatures across features
8d7163d
@imrn99
test: add simple testing for ViewData
544f6f4
@imrn99
refactor: replaced Vec by ViewData in View structure
b5ca815
@imrn99
fix: adjust raw_val method to match new data holding type
9963bc6
@imrn99
fix: add impl Sync/Send to ViewData structure
ef2ead5 
this is somewhat of a cheesy fix, but the pointer are not supposed to
be manipulated by the user anyway, so we assume it is safe
@imrn99
refactor: pointer & layout of ViewData are now private fields
61b045a
@imrn99
docs: update view::parameters module
f5152a5
@imrn99
fix: remove useless as_ref call in get method of ViewData
e4fdf79
@imrn99
docs: update view module
b46731f
@imrn99
refactor: removed duplicate constructors of View
30396ce 
Since the feature-specific initialization is done in ViewData methods,
there's no need for separate implementation anymore at this level
@imrn99
fix: ensure consistency of view init
c22594e
@imrn99
fix: ViewData tests
dd60029 
it was, indeed, a fluke that it worked before
@imrn99 imrn99 merged commit b06724d into master Dec 21, 2023
4 checks passed
@imrn99 imrn99 deleted the better-views branch December 21, 2023 18:43
@imrn99 imrn99 restored the better-views branch December 22, 2023 13:27
@imrn99 imrn99 mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@imrn99