View Implementation #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scalar implementation usign the base structure does not seem trivial
generic traits made stride computing too much of a hassle
need to add unit test
criterion produces a nice violin plot with performances for on the layout
no variation between cases appear when dim changes
no performance loss caused by the convoluted Index<> implementation for views
weird behavior on 3D unchecked accesses; cf. comments in code
issue lies with the blackbox?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gemv: Vector-Matrix product computation; this puts numbers on the importance of a correct layoutview_init: compare initialization of views & usual vectors; allows to spot scaling issueview_access: compare data access of views & usual vectors; allows to spot scaling issue