Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate from deprecated Graph (old) to Time series #5

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

aschaber1
Copy link
Contributor

Hello, I update the dashboard to make use of the (newer) Time series graphs.

I used the automated Migrate button in Grafana. But maybe it helps.
The diff is still huge, because now everything is in " as well as the ordering has changed.

Please have a look.
Best regards
Alexander

@imusmanmalik imusmanmalik self-assigned this Apr 1, 2024
@imusmanmalik imusmanmalik self-requested a review April 1, 2024 13:58
@imusmanmalik imusmanmalik added the enhancement New feature or request label Apr 1, 2024
Copy link
Owner

@imusmanmalik imusmanmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aschaber1 for the contribution! LGTM

@imusmanmalik imusmanmalik merged commit b6a425d into imusmanmalik:main Apr 1, 2024
2 checks passed
@aschaber1
Copy link
Contributor Author

Hello @imusmanmalik thank you for the merge, please have a closer look, I just learned more about jsonnet yesterday and I believe I did not follow those rules. My contributions was merely plain json.

joscherrer added a commit to joscherrer/cert-manager-mixin that referenced this pull request Oct 13, 2024
imusmanmalik pushed a commit that referenced this pull request Oct 14, 2024
* reintroduce dashboard variables to fix regression from #5

* fix missing format string operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants