Conserve labels in query result, add selector support #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using your mixin for quite some time but ran into an issue when I implemented label based alerting. The certificate alert queries currently strip away all labels except for the ones select in the
by
clause.Then I had a closer look at the queries and in my opinion you don't need the aggregations for
CertManagerCertExpirySoon
andCertManagerCertNotReady
. The certificates are already unique through the namespace + name combination and it's not possible to group them, therefore I removed the aggregations.For
CertManagerHittingRateLimits
I looked at the metric and from what I seesum without (method, path)
should be sufficient for aggregation.Last I would find it very useful to set a
selector
variable similar how it's done in other mixins, examples:I refactored
certManagerJobLabel
tocertManagerSelector
and placed it in all alerts. I also updated the tests.