Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gittuf workflows #41

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Fix gittuf workflows #41

merged 2 commits into from
Sep 5, 2024

Conversation

adityasaky
Copy link
Member

No description provided.

Summary of changes:
* Set key permission to 600 for SSH signing key
* Use released version of gittuf via installer workflow
* Use setup-gitsign workflow instead of installing from source

Signed-off-by: Aditya Sirish <[email protected]>
@adityasaky adityasaky changed the title [WIP] Record attestations for open PRs Fix gittuf workflows Sep 4, 2024
@adityasaky adityasaky marked this pull request as ready for review September 4, 2024 16:54
@marcelamelara
Copy link

Besides the version updates on the actions, are there any functionality changes introduced here?

@adityasaky
Copy link
Member Author

https://github.com/in-toto/attestation-verifier/pull/41/files#diff-3df7c2aa640b297b47c907c2ebe29000581edf28349f9d3e8d04aeedfe216d30R35

gittuf changed how ssh keys are used for signing, and this permission must be set on private keys. Basically, gittuf now uses ssh-keygen to sign, and ssh-keygen has this requirement.

marcelamelara
marcelamelara previously approved these changes Sep 4, 2024
Copy link

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @adityasaky !

@trishankatdatadog trishankatdatadog merged commit cb51447 into main Sep 5, 2024
2 checks passed
@trishankatdatadog trishankatdatadog deleted the gittuf-attestations branch September 5, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants