Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyLint Workflow for PRs #26

Merged
merged 14 commits into from
Jan 17, 2024
Merged

Add PyLint Workflow for PRs #26

merged 14 commits into from
Jan 17, 2024

Conversation

inFocus7
Copy link
Owner

@inFocus7 inFocus7 commented Jan 11, 2024

Description

Introduces Python linter for PRs, to ensure all's good.

Fixes #12

There are some ignored linter issues due to how Gradio handles inputs and outputs where I couldn't find a way to use tuples/dataclasses to minify some functions.

  • Get a 10/10 rating before merging.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before you submit your pull request, please review the following checklist:

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have updated the Dockerfile with any new dependencies (if applicable).

Additional context

Add any other context about the pull request here.

@inFocus7 inFocus7 enabled auto-merge January 17, 2024 00:53
@inFocus7 inFocus7 disabled auto-merge January 17, 2024 00:54
@inFocus7 inFocus7 merged commit 6703921 into main Jan 17, 2024
1 check passed
@inFocus7 inFocus7 deleted the add-linter-on-prs branch January 17, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Python linter workflow
1 participant