Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add music cover video preview generation #33

Merged
merged 4 commits into from
Jan 21, 2024

Conversation

inFocus7
Copy link
Owner

Description

Adds preview generation so you don't have to generate the complete video.

Fixes #32

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tried locally with different lengths, with the edge-case - where the duration > audio.length - working as expected.

Checklist:

Before you submit your pull request, please review the following checklist:

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have updated the Dockerfile with any new dependencies (if applicable).
  • I have added these changes to the latest changelog for an upcoming release.

Additional context

Add any other context about the pull request here.

@inFocus7 inFocus7 added the enhancement New feature or request label Jan 21, 2024
@inFocus7 inFocus7 linked an issue Jan 21, 2024 that may be closed by this pull request
2 tasks
Copy link
Owner Author

@inFocus7 inFocus7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅🏼 👍🏼

@inFocus7 inFocus7 merged commit b709603 into main Jan 21, 2024
1 check passed
@inFocus7 inFocus7 deleted the feat/create-music-video-preview branch January 21, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature/Enhancement]: Generate Preview [Feature/Enhancement]: Set up automated changelog generation
1 participant