Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show notifications from others #2491

Merged
merged 17 commits into from
Nov 28, 2024
Merged

feat: show notifications from others #2491

merged 17 commits into from
Nov 28, 2024
+671 −303

Conversation

kueda
Copy link
Member

@kueda kueda commented Nov 27, 2024 •
edited
Loading

  • divides Notifications into two tabs, one for obs by you, one for other observations
  • bottom tabs notification icon will show an indicator if you have unviewed notifications in either tab
  • adjust size and spacing of Header5 and moves old Header5 style to Header6 (closes Add a new text style #2480)
  • lots of fun TypeScript conversion
  • force all tabs to be only 1 line of text

Closes #2451

@kueda
chore: convert ObsNotification.js to TypeScript
965ef92
@kueda
chore: more TypeScript conversion
e53426a
@kueda
chore: convert test from ts to js
c93fe97
@kueda
chore: use existing TypeScript types; move some to better places
26be0f8
@kueda
wip: split notifications into tabs; still need to update notif text
1e922da
@kueda
fix: prevent new notifications from loading forever
3b9ce29 
Apparently if you wrap FlashList in a ScrollView, the onEndReached callback
calls forever.
@kueda
show text w/ correct username for obs by others
dbb6363
@kueda
show photos for obs by others
fe97538
@kueda
feat: resize Heading5 and add Heading6 (closes #2480)
a1a1787
@kueda
fix: use tab name and typography in designs
a87b214
@kueda
fix: mark remote observations as viewed
1fb5936
@kueda
feat: show indicator in tab if unviewed notifications
a9928c5
@kueda
fix: ellipsize overflowing text in tabs
997c98d 
Also make Notification tab text unique strings b/c they have different
character count constraints.
@kueda
test: update snapshots and tests
99120ba
@kueda kueda marked this pull request as ready for review November 27, 2024 20:42
@kueda kueda merged commit 7f9a272 into main Nov 28, 2024
11 checks passed
@kueda kueda deleted the 2451-notifications-from-others branch November 28, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new text style Include notifications about observations by others in Notifications
1 participant
@kueda