Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show notifications from others #2491

Merged
merged 17 commits into from
Nov 28, 2024
Merged

feat: show notifications from others #2491

merged 17 commits into from
Nov 28, 2024

Commits on Nov 27, 2024

  1. chore: convert ObsNotification.js to TypeScript

    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    965ef92 View commit details
    Browse the repository at this point in the history

  2. chore: more TypeScript conversion

    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    e53426a View commit details
    Browse the repository at this point in the history

  3. chore: convert test from ts to js

    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    c93fe97 View commit details
    Browse the repository at this point in the history

  4. chore: use existing TypeScript types; move some to better places

    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    26be0f8 View commit details
    Browse the repository at this point in the history

  5. wip: split notifications into tabs; still need to update notif text

    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1e922da View commit details
    Browse the repository at this point in the history

  6. fix: prevent new notifications from loading forever 

    Apparently if you wrap FlashList in a ScrollView, the onEndReached callback
calls forever.
    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    3b9ce29 View commit details
    Browse the repository at this point in the history

  7. show text w/ correct username for obs by others

    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    dbb6363 View commit details
    Browse the repository at this point in the history

  8. show photos for obs by others

    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    fe97538 View commit details
    Browse the repository at this point in the history

  9. feat: resize Heading5 and add Heading6 (closes #2480)

    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    a1a1787 View commit details
    Browse the repository at this point in the history

  10. fix: use tab name and typography in designs

    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    a87b214 View commit details
    Browse the repository at this point in the history

  11. fix: mark remote observations as viewed

    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    1fb5936 View commit details
    Browse the repository at this point in the history

  12. feat: show indicator in tab if unviewed notifications

    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    a9928c5 View commit details
    Browse the repository at this point in the history

  13. fix: ellipsize overflowing text in tabs 

    Also make Notification tab text unique strings b/c they have different
character count constraints.
    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    997c98d View commit details
    Browse the repository at this point in the history

  14. test: update snapshots and tests

    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    99120ba View commit details
    Browse the repository at this point in the history

  15. chore: clean up

    @kueda
    kueda committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    4952faa View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. Merge branch 'main' into 2451-notifications-from-others

    @kueda
    kueda committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    77fcd31 View commit details
    Browse the repository at this point in the history

  2. fix: update tab indicators when notifications pulled to refresh

    @kueda
    kueda committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    95ace6d View commit details
    Browse the repository at this point in the history