Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: focus on last photo in MediaViewer after removing others #2433

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: focus on last photo in MediaViewer after removing others #2433

wants to merge 2 commits into from

Conversation

israr002
Copy link
Contributor

@israr002 israr002 commented Nov 15, 2024 •
edited by kueda
Loading

Closes #1078

@kueda kueda changed the title add scroll logic on index change fix: focus on last photo in MediaViewer after removing others Nov 15, 2024
kueda
kueda requested changes Nov 15, 2024
View reviewed changes
Copy link
Member

@kueda kueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have failing tests in tests/integration/PhotoDeletion.test.js that you need to address.

@kueda kueda self-assigned this Nov 19, 2024
@israr002 israr002 requested a review from kueda November 20, 2024 18:21
@kueda
Copy link
Member

kueda commented Nov 22, 2024

Sorry I didn't get to this this week, @israr002. I will review this early next week.

kueda
kueda requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@kueda kueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well in Android, but in iOS (iPhone SE 3rd gen, iOS 18.1.1), when you delete the last of 3 photos, it skips back to the first photo. It should focus on the second photo like it does in Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kueda kueda kueda requested changes

Assignees

@kueda kueda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing last two photos from MediaViewer doesn't focus on the remaining one
2 participants
@israr002 @kueda