resize_with_crop_or_pad gives better overall results than central crop to resize (which squeezes) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see inaturalist/iNaturalistMLWork#24 for some results
|
I think this is failing CI because the CI system is running keras3 which requires our models to be in a different format than keras2 did. |
… on multiple python versions
pleary
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
I added specific versions to the requirements txt files we use to install dependencies. A newer version of something must have been released recently, and since we weren't using fixed versions, a new major version of Keras was being used for tests. Tests are now passing so I'll merge this in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see inaturalist/iNaturalistMLWork#24 for some results