Add build info #25
Merged
Add build info #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleary
approved these changes
Jul 2, 2024
lib/inat_vision_api.py
Outdated
| @@ -77,6 +78,14 @@ def h3_04_bounds_route(self): | |||
| return f"Unknown taxon_id {taxon_id}", 422 | |||
| return results_dict | |||
|
|
|||
| def build_info_route(self): | |||
| return { | |||
| "git_branch": os.environ["GIT_BRANCH"], | |||
There was a problem hiding this comment.
This will raise an error if these environment variables are not defined. Maybe that's desired. Some of the other versions will handle that a little better by returning empty hashes or nothing at all. The node API for example will also return a 500 if this endpoint fails, so in deployments where these environment variables are not defined, a handful of the build_info endpoints in the different codebases will render a 500 error of some sort
There was a problem hiding this comment.
I replaced them by os.getenv("xxx", "") to avoid such failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.