Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix 48 #50

Merged
merged 6 commits into from
Feb 25, 2022
Merged

WIP: Fix 48 #50

merged 6 commits into from
Feb 25, 2022

Conversation

marcvs
Copy link
Collaborator

@marcvs marcvs commented Feb 25, 2022

Addresses #48 :

Handle matching in case value is not a list.

Yet, the test fails, even though only one email of two email addresses needs to match

@marcvs
Copy link
Collaborator Author

marcvs commented Feb 25, 2022

@lburgey: Before I remove all references to OneOf, I thought you'd better have a say on this ;)

@lburgey
Copy link

lburgey commented Feb 25, 2022

@lburgey: Before I remove all references to OneOf, I thought you'd better have a say on this ;)

I think you can remove it, so go ahead

@dianagudu
Copy link
Contributor

I'd suggest to keep OneOf and simply subclass from N_Of with n=1. Not just because I use it in motley_cue :), but I'd imagine it's a common use case, and then it's just nice to have a shorthand.

@marcvs
Copy link
Collaborator Author

marcvs commented Feb 25, 2022

ok

@marcvs marcvs merged commit 937a559 into master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants