Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nix depsSha256 #322

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented Jan 3, 2025

No description provided.

@keynmol
Copy link
Contributor

keynmol commented Jan 3, 2025

What's the smallest possible workflow that we can have that makes sure the nix installation works?
Can you run the flake locally?

I'm happy to approve random hash changes (which is already terrifying), but if I could have a little bit of confidence that stuff works for Nix folks I'd be less worried

@kubukoz
Copy link
Contributor Author

kubukoz commented Jan 4, 2025

A CI workflow is easy, what's harder is an auto-updater that'll let you not worry about it at all. A failing workflow would tell you what hash to use, but it'd fail on essentially every Scala Steward PR :/

If we can figure out an auto-updater, we can have Steward run an extra command that'll update the hash as well. Its PRs would have to be either

  • batched (multiple libs per PR), or
  • merged sequentially (merge PR 1, update PR 2 with main, wait for CI, merge, update PR 3...)
  • merged in a merge queue

At the moment, even as a Nix user I'm not too mad about the hash changes. I just stay pinned to the last version where somebody updated the hash 😅 but it's not a scalable approach.

One thing we could do right off the bat is give users the ability to override the deps hash locally, so that they don't need a PR like this.

Another thing... if we have an auto-updater, we could have a scheduled workflow that runs it. That'd sort of circumvent the problem of "a series of lib updates merged in a sequence", giving the Nix build a sort of "eventually working" status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants