Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fast operator evaluation for tensor-product discretizations #362

Draft
wants to merge 57 commits into
base: main
Choose a base branch
from

Conversation

a-alveyblanc
Copy link
Contributor

@a-alveyblanc a-alveyblanc commented Sep 6, 2024

Supersedes #313, #354

Adds:

  • Fast operator evaluation for tensor-product discretizations
  • Metadata (tags) relevant to tensor-product discretizations used during (eager and lazy) compilation
  • WADG + Overintegration (+ fast operator evaluation in the case of tensor-product elts)

Non-essential transformations will be added in a later PR. This is to keep this (already large) PR manageable.

TODOs:

  • Gradient
    • Strong form
    • Weak form
  • Divergence
    • Strong form
    • Weak form
  • Mass
  • Inverse mass
  • Support overintegration + fast operator evaluation
  • Face mass
  • Add generic bilinear form evaluation
  • Rewrite op.py to use generic bilinear form evaluation

cc @MTCam

@inducer
Copy link
Owner

inducer commented Sep 7, 2024

Should this be marked draft given that there are pending TODOs?

@a-alveyblanc a-alveyblanc marked this pull request as draft September 7, 2024 21:27
grudge/op.py Outdated
Comment on lines 416 to 417
tagged=(FirstAxisIsElementsTag(),
OutputIsTensorProductDOFArrayOrdered(),),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tagged=(FirstAxisIsElementsTag(),
OutputIsTensorProductDOFArrayOrdered(),),
tagged=(FirstAxisIsElementsTag(),
OutputIsTensorProductDOFArrayOrdered(),),

buh-bye!

grudge/bilinear_forms.py Outdated Show resolved Hide resolved
grudge/bilinear_forms.py Outdated Show resolved Hide resolved
grudge/bilinear_forms.py Outdated Show resolved Hide resolved
grudge/bilinear_forms.py Outdated Show resolved Hide resolved
grudge/bilinear_forms.py Outdated Show resolved Hide resolved
grudge/bilinear_forms.py Outdated Show resolved Hide resolved
grudge/bilinear_forms.py Outdated Show resolved Hide resolved
grudge/bilinear_forms.py Outdated Show resolved Hide resolved
grudge/bilinear_forms.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants