-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fast operator evaluation for tensor-product discretizations #362
Draft
a-alveyblanc
wants to merge
57
commits into
inducer:main
Choose a base branch
from
a-alveyblanc:tensor-product-operators
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…product-operators
Should this be marked draft given that there are pending TODOs? |
…product-operators
inducer
reviewed
Oct 7, 2024
grudge/op.py
Outdated
Comment on lines
416
to
417
tagged=(FirstAxisIsElementsTag(), | ||
OutputIsTensorProductDOFArrayOrdered(),), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
tagged=(FirstAxisIsElementsTag(), | |
OutputIsTensorProductDOFArrayOrdered(),), | |
tagged=(FirstAxisIsElementsTag(), | |
OutputIsTensorProductDOFArrayOrdered(),), |
buh-bye!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #313, #354
Adds:
Non-essential transformations will be added in a later PR. This is to keep this (already large) PR manageable.
TODOs:
op.py
to use generic bilinear form evaluationcc @MTCam