Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c_execution: remove unused source_suffix argument to GCCToolchain #830

Merged
merged 3 commits into from
Mar 1, 2024
Merged

c_execution: remove unused source_suffix argument to GCCToolchain #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddcfbf8
c_execution: remove unused source_suffix argument to GCCToolchain
alexfikl Mar 1, 2024
bc8b3a1
c_execution: add optional arguments to GCCToolchain
alexfikl Mar 1, 2024
fafbc45
test: remove test of GCCtoolchain
alexfikl Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions loopy/target/c/c_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,16 +280,17 @@ def __init__(self, toolchain=None,
# default args
self.toolchain = GCCToolchain(
cc="gcc",
ld="ld",
cflags="-std=c99 -O3 -fPIC".split(),
ldflags="-shared".split(),
libraries=[],
library_dirs=[],
defines=[],
undefines=[],
source_suffix="c",
so_ext=".so",
o_ext=".o",
include_dirs=[])
include_dirs=[],
features=set())

if toolchain is None:
# copy in all differing values
Expand Down
5 changes: 0 additions & 5 deletions test/test_c_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,11 +336,6 @@ def eval_tester(knl):
# the default (non-guessed) toolchain!
__test(eval_tester, ExecutableCTarget, compiler=ccomp)

# and test that we will fail if we remove a required attribute
del ccomp.toolchain.undefines
with pytest.raises(AttributeError):
__test(eval_tester, ExecutableCTarget, compiler=ccomp)

# next test that some made up compiler can be specified
ccomp = CCompiler(cc="foo")
assert isinstance(ccomp.toolchain, GCCToolchain)
Expand Down
Loading