-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement insert points #69
Open
sampotter
wants to merge
8
commits into
inducer:main
Choose a base branch
from
sampotter:implement-insert-points
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
aeb1546
enable use of insert_points in meshpy.tet.tetrahedralize (wip)
e1652ea
add test_insert_points.py example
023ce61
add test_insert_points.py example
c12b0cd
Merge branch 'implement-insert-points' of https://github.com/sampotte…
d637c6a
don't use Options's keywords
4ce9404
add test for insert_points
04e71d5
fix flake8 failures
2ce10c0
fix flake8 failure in test/test_meshpy.py
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import logging | ||
import numpy as np | ||
|
||
from meshpy.tet import MeshInfo, Options, build | ||
|
||
if __name__ == '__main__': | ||
logger = logging.getLogger('test_insert_points.py') | ||
|
||
points = [(0, 0, 0), | ||
(0, 0, 1), | ||
(1, 0, 0), | ||
(1, 0, 1), | ||
(1, 1, 0), | ||
(1, 1, 1), | ||
(0, 1, 0), | ||
(0, 1, 1)] | ||
|
||
facets = [(0, 1, 3, 2), | ||
(2, 3, 5, 4), | ||
(4, 5, 7, 6), | ||
(6, 7, 1, 0), | ||
(0, 2, 4, 6), | ||
(1, 3, 5, 7)] | ||
|
||
mesh_info = MeshInfo() | ||
mesh_info.set_points(points) | ||
mesh_info.set_facets(facets) | ||
|
||
# Insert an interior point of the cube as a constrained point | ||
interior_point = (0.33, 0.7, 0.91) | ||
|
||
insert_points_mesh_info = MeshInfo() | ||
insert_points_mesh_info.set_points([interior_point]) | ||
|
||
mesh = build(mesh_info, max_volume=0.25, | ||
insert_points=insert_points_mesh_info) | ||
|
||
mesh_points = np.array(mesh.points) | ||
min_dist = np.sqrt(np.sum((interior_point - mesh_points), axis=1)**2).min() | ||
|
||
if min_dist > 0: | ||
logger.error('tetrahedron mesh does not contain contrained point') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a version of this to the (pytest-driven) tests under
test/
, to make sure this doesn't get inadvertently broken?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please also take care of the Flake8 linter failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't you mention in #70 that this PR was no longer needed? Could you explain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. But this appears to be the correct way to implement this and IMO it makes sense to cover tetgen's interface regardless of whether there are parts of it that are a little redundant. Some people looking for a wrapper library for tetgen may be familiar with one approach and not the other.