Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New board update #209

Merged
merged 8 commits into from
Mar 14, 2024
Merged

New board update #209

merged 8 commits into from
Mar 14, 2024

Conversation

zcardwell
Copy link
Contributor

Just updating the board! Removed folks just according to my current list (happy to add folks back in!).

Highlights:

  • Made "email" optional since I haven't built them on the google admin page yet.
  • Commented out hpricot - couldn't get it to install and looking at the repo looks like it is deprecated. I can build with it, but as a nonrubyist, I don't know if I'm inviting programming doom down the line - just wanted to test the page changes before pushing.
  • Formatted photos and etc.

If I missed anything just let me know!

@zcardwell zcardwell self-assigned this Mar 14, 2024
Copy link

@ejmudrak ejmudrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 couldn't find any typos on the members added at least.

app/views/site/about.html.erb Show resolved Hide resolved
Gemfile Show resolved Hide resolved
Copy link
Member

@armilam armilam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter is mad about vulnerable gems, but that is something we can resolve separately. This looks like it should work. Go ahead and merge it - hopefully the auto-deploy still works 😄

@zcardwell zcardwell merged commit 029ee8f into main Mar 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants