Refactor get model dimensions from labels #126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when setting up a model using labels, it is not possible to set up both A and B matrix stubs from the same labels dictionary, due to the implied absence/presence of the
actions
key.This isn't a great user experience - ideally someone should be able to specify all the labels in a single variable, and then generate all constituent parts of the model from that.
E.g. the following label spec:
raises the following error from
create_A_matrix_stub()
:This change:
create_A_matrix_stub()