-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed fixes to control.py and utils.py #56
base: master
Are you sure you want to change the base?
Conversation
spetey
commented
Dec 15, 2021
- control.py's action_marginals should sum only over the first time step, 2) utils.py's sample(probabilities) throws an error with the argument "squeezed"
…over the first time step, 2) utils.py's sample(probabilities) throws an error with the argument squeezed
thanks for this @spetey -- before I run the CI test-suite, can you please remove the extra files from your commit (those ones committed besides |
… should only sum over time 0, and sample(probabilities) throws an error when squeezed
…ly sum over time 0, and squeezing sample(probabilities) throws an error
Ugh, I've tried to reset to HEAD~1 and ignore the "egg-info" directory that
was auto-added somehow, but then there were conflicts because the upstream
repo had changed, and then it stopped ignoring the "egg-info" ... I find
git terribly confusing, I tried to fix it as best I could, and opened
another pull request. Thanks again for your patience.
Steve
…On Wed, Dec 15, 2021 at 5:43 AM conorheins ***@***.***> wrote:
thanks for this @spetey <https://github.com/spetey> -- before I run the
CI test-suite, can you please remove the extra files from your commit
(those ones committed besides utils.py and control.py?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#56 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPMDVDQOFJVG4TKWR7KA4TURBWLDANCNFSM5KCQFIIA>
.
|
Hey @spetey I've pushed another branch for the documentation that also included the fix to |
I've added a gitignore *.egg.info to a PR, so this won't be an issue going forward |