-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation added, status bars added, one bug fix, some tidying #1
Open
lasermanick
wants to merge
31
commits into
infer-actively:main
Choose a base branch
from
lasermanick:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqdm status bars added to the generative and supervised scripts
Original did not add the normalization transform to the transform list (so MNIST images were not normalised - only scaled to range [0,1] by ToTensor()). Fix is to replace '+' with '+='.
Change default normalization and correct documentation
Added/edited doc strings
Remove redundant initialisation code and unused import (and add one doc string)
Add doc strings to FCLayer methods
Add docstrings and other comments to PCModel class. Also remove one redundant import.
Add some doc strings to utils.py
Add some comments, minor reformatting, add option to disable tqdm progress bars, change some of the parameters (with original values added as comments)
Minor reformatting to be consistent with generative.py , add option to disable tqdm progress bars, change one parameter (with original value added as comment)
Comment out unused (not implemented) layer classes and associated imports
Add comments to PCModel.train_batch_generative()
Added fixed precisions in the form of (identity matrix x constant) where constant is set by layer. Can be disabled. Implemented by optionally calculating precision scaled error term. Execution time increases by ~10% when enabled.
Add default=False to fixed_preds parameter in test_updates() (to match train_updates())
Adjust progress display to match generative.py. (Also use reduced dataset by default, again matching generative.py)
An environment definition. For example, use as follows to define a new environment: conda env create -f environment.yml
Creates figures from Neptune data using Plotly. Defines a class NickFig and some standard colours. For each figure, creates a definition. Finally, creates instances of NickFig with selected definition(s).
Add transforms for gaussian additive noise and update MNIST and FashionMNIST classes to optionally use these. Add scaling to FashionMNIST (following MNIST). Add save_csv() and plot_imgs_alt() methods. Add some comments.
Add comments. Add free energy calculation. Add logging to Neptune. Add code for precision scale factor and precision coverage.
Replace improper use of "is" with "==" x 2.
Added Neptune logging. NOTE: Needs further updates to be aligned with generative.py.
Added Neptune logging. Added plot_example_data_MNIST(). Moved accuracy calculation to calc_accuracy(). Added print_batch_stats(). Made json logging optional. Added saving of label predictions. Added loops for 2D parameter scans.
Ignoring Neptune cache, generated figures, secret keys (constants.py), and temporary/scratch files.
Renamed after adding environment_macos.yml
Use pytorch-nightly channel to enable Metal (MPS) acceleration in pytorch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most commits add documentation through docs strings or inline comments
The first commit adds tqdm status bars (a later commit adds the option to disable these)
One normalisation bug fixed
Some tidying, including:
to avoid warnings, commenting out the unused layer types that have not been implemented)
removing unused imports