This repository has been archived by the owner on May 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Bumps Infinispan to 8.2.3 (iss #12) #13
Open
vdzhuvinov
wants to merge
8
commits into
infinispan:main
Choose a base branch
from
vdzhuvinov:iss12
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristantarrant
suggested changes
Nov 22, 2016
/** | ||
* The instances of this class, keyed by Infinispan cache name. | ||
*/ | ||
private static Map<String,RedisStore> instances = new Hashtable<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting (no space after the comma)
* @return The instances of this class as an unmodifiable map, keyed by | ||
* Infinispan cache name. | ||
*/ | ||
public static Map<String,RedisStore> getInstances() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting
@@ -37,8 +51,13 @@ | |||
@Override | |||
public void init(InitializationContext ctx) | |||
{ | |||
RedisStore.log.info("Redis cache store initialising"); | |||
RedisStore.log.info("Initialising Redis store for cache " + ctx.getCache().getName()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note for the future: it would be nice if info and above logging should use jboss logging loggers for i18n.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps Infinispan to 8.3.2 to use org.infinispan.configuration.parsing.Parser instead of Parser80.
Not sure if the schema should be bumped as well? org.infinispan.test.TestingUtil doesn't include 8.2 as valid schema version.