WIP: Add ktx library module #74
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aksi0m the PR is not completely ready, but I wanted some early feedback from you, if you can manage. |
davidvinf
reviewed
Jul 7, 2021
Comment on lines
22
to
36
| suspend fun authenticate( | ||
| params: PromptParams, | ||
| ): Flow<Goldfinger.Result> | ||
|
|
||
| suspend fun encrypt( | ||
| params: PromptParams, | ||
| key: String, | ||
| value: String, | ||
| ): Flow<Goldfinger.Result> | ||
|
|
||
| suspend fun decrypt( | ||
| params: PromptParams, | ||
| key: String, | ||
| value: String, | ||
| ): Flow<Goldfinger.Result> |
There was a problem hiding this comment.
The functions returning Flow should not be suspending, which you can do easily since in the implementation inGoldfingerFlow is not suspending
added 6 commits
July 12, 2021 08:21
|
Updated kotlint to 1.5.10 and coroutines to 1.5.0 |
|
@mdocevski-infinum & @davidvinf Guys, can we fix the conflicts & merge this PR? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added analog of GoldfingerRx that supports kotlin flows, named GoldfingerKtx in new module ktx.