feat: release GIL for most "run_block_on" calls #388
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps most
run_block_on
calls in apy.allow_threads
function, releasing the Python GIL for the duration of therun_block_on
call. This is especially important forPartitionConsumerStream.next
which might block indefinitely.The issue arose with me, when running a
PartitionConsumer
in a separate thread and using thestream
method. The underlying call toPartitionConsumerStream.next
was waiting for incoming messages while holding the Python GIL, effectively prohibiting the main thread to do any work.I think that releasing the GIL is mostly important for the
PartitionConsumerStream.next
method, because it may block indefinitely (if no messages arrive), but I wrapped all otherrun_block_on
calls as well, while I was at it.I left out the instances of
run_block_on
in the context ofCloud
andCloudAuth
as I have not worked with those, yet.